Strange error in rivals

Status: under development
Branch: https://gitlab.com/joomleague/joomleague/tree/3.0.0

Moderator: And_One

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Strange error in rivals

Postby MSK » Thu Nov 26, 2015 10:54 am

In rivals we can see H2H statistics with one team and others.
But is counts something strange. It seems, it's a bug.
For example if we have Double Round Roubin - there are 2 matches between the teams. Both will be counted. But if we have 1 match or Single Round Robin where we have 1 match between these teams - this match doesn't count in rivals if this team has played away. In the rivals's page of the home team, this match will be counted.

Mb there are some moments I don't know, but I think it has place and it is a bug.

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Re: Strange error in rivals

Postby MSK » Mon Jan 18, 2016 10:37 am

Up!
This is a bug, it is in JL 2.x and 3.x.
If a TEAM_1 doesn't have HOME matches with a TEAM_2, in TEAM_1's Rivals there aren't any summary about TEAM_2. In TEAM_2's rivals there are all the matches. If TEAM_1 plays home with TEAM_2 - all the rivals will be appeared in TEAM_1 rivals.

Look:
I have created a query where I want to look at matches between teams id 7 and 14. team1_id (HOME) plays with team2_id (AWAY)
Jl-home.png



As we can see - all the matches are AWAY for team_id = 7 so in the team_id=7's rivals we don't see anything about matches with the team_id=14.
How to fix it? I think the decision will be the same as for 2.x as for 3.x of JL...
You do not have the required permissions to view the files attached to this post.

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Re: Strange error in rivals

Postby MSK » Mon Jan 18, 2016 10:49 am

As I understand , /components/com_joomleague/models/rivals.php needs fixing....

User avatar
comraden
Joomleague Core Developer
Joomleague Core Developer
Posts: 1291
Joined: Thu Aug 16, 2007 2:27 pm
Location: Poland, Lublin
Contact:

Re: Strange error in rivals

Postby comraden » Tue Jan 19, 2016 4:14 am

bug confirmed
I fixed it, but I will push to repo ... this week (I will try).
:thx:

also fixed include in counting of published/unpublished projects
http://llk.pl::jl_1.6 | jl_2.x | jl_3.x testing/production enviroment
samiec alfa koncernu 'Cham_Burak_Prostak' || proved: the most annoying person on the forum

User avatar
comraden
Joomleague Core Developer
Joomleague Core Developer
Posts: 1291
Joined: Thu Aug 16, 2007 2:27 pm
Location: Poland, Lublin
Contact:

Re: Strange error in rivals

Postby comraden » Thu Jan 21, 2016 4:13 am

fixed and pushed to master.
please check it out.
http://llk.pl::jl_1.6 | jl_2.x | jl_3.x testing/production enviroment
samiec alfa koncernu 'Cham_Burak_Prostak' || proved: the most annoying person on the forum

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3610
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Strange error in rivals

Postby And_One » Thu Jan 21, 2016 11:34 am

comraden wrote:fixed and pushed to master.
please check it out.


congratulations to your first 3.x commit ;)

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Re: Strange error in rivals

Postby MSK » Thu Jan 21, 2016 2:18 pm

comraden wrote:fixed and pushed to master.
please check it out.


Seems it works both forJL 2.x and 3.x now )) :thx: :thx: :thx:

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

Re: Strange error in rivals

Postby Heart » Thu Jan 21, 2016 4:34 pm

And_One wrote:
comraden wrote:fixed and pushed to master.
please check it out.


congratulations to your first 3.x commit ;)

it was pushed to master (old) branch, not 3.x ;)

User avatar
comraden
Joomleague Core Developer
Joomleague Core Developer
Posts: 1291
Joined: Thu Aug 16, 2007 2:27 pm
Location: Poland, Lublin
Contact:

Re: Strange error in rivals

Postby comraden » Thu Jan 21, 2016 4:44 pm

it was pushed to master (old) branch, not 3.x ;)

yeah ;)
My 3.0.0 testing enviroment are little mess now, so I can't test it.

Seems it works both forJL 2.x and 3.x now ))

eee, imposible, test it deeply :confused:
http://llk.pl::jl_1.6 | jl_2.x | jl_3.x testing/production enviroment
samiec alfa koncernu 'Cham_Burak_Prostak' || proved: the most annoying person on the forum

User avatar
comraden
Joomleague Core Developer
Joomleague Core Developer
Posts: 1291
Joined: Thu Aug 16, 2007 2:27 pm
Location: Poland, Lublin
Contact:

Re: Strange error in rivals

Postby comraden » Thu Jan 21, 2016 4:59 pm

Fatal error: Call to undefined method JoomleagueModelJoomleague::getSeasonProjects() in /home/val/Dokumenty/Repo/gitlabjoomleague/joomleague/com_joomleague/administrator/components/com_joomleague/views/joomleague/view.html.php on line 232

error when I try access joomleague backend...
So I will try fix this and do some work on 3.0.0
http://llk.pl::jl_1.6 | jl_2.x | jl_3.x testing/production enviroment
samiec alfa koncernu 'Cham_Burak_Prostak' || proved: the most annoying person on the forum

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Re: Strange error in rivals

Postby MSK » Thu Jan 21, 2016 5:28 pm

comraden wrote:
it was pushed to master (old) branch, not 3.x ;)

yeah ;)
My 3.0.0 testing enviroment are little mess now, so I can't test it.

Seems it works both forJL 2.x and 3.x now ))

eee, imposible, test it deeply :confused:


Maybe it needs to more deep testing...but seems it works on me (JL 3.x - last git). I have added your edits to my 3.x project.

Fatal error: Call to undefined method JoomleagueModelJoomleague::getSeasonProjects() in /home/val/Dokumenty/Repo/gitlabjoomleague/joomleague/com_joomleague/administrator/components/com_joomleague/views/joomleague/view.html.php on line 232

It's ok for me... I haven't got errors, but it will be nice if you look at this in 3.x..

MSK
.
Posts: 72
Joined: Sun Jul 21, 2013 12:12 pm

Re: Strange error in rivals

Postby MSK » Thu Jan 21, 2016 7:57 pm

MSK wrote:Maybe it needs to more deep testing...but seems it works on me (JL 3.x - last git). I have added your edits to my 3.x project.

Sorry, I have PRElast git.
In the last git I have a bug:
Fatal error: Call to undefined method JoomleagueModelPerson::getPlayerEvents() in /home/joomleaguetest/components/com_joomleague/views/player/tmpl/default_playerstats.php on line 174
I think Bluefox will fix this Player's view. Mb your error depends on this bug.

User avatar
Bluefox
.
Posts: 312
Joined: Tue Aug 27, 2013 11:26 am
Joomleague version: 2.0.x
Location: Friesland, Netherlands
Contact:

Re: Strange error in rivals

Postby Bluefox » Wed Jan 27, 2016 8:11 pm

@msk you are totally right.

Was missing in action (other priority's) but am going to revert the change of player-view to what it was and then try to fix the problems in that + person view.

// Edit //
hmm, seems to be giving more problems for now so maybe better to leave it as it was.
Ah well will spend some time to it.
Help can be asked in the forum


Return to “3.0.22.57ae969-Blue (Joomla: 3.x)”

Who is online

Users browsing this forum: No registered users and 1 guest

cron