Another problem about substitution managment

Status: finished.
Here you can find pre-releases of JoomLeague, Errors and problems with these versions should only be discussed in this board.
NOTICE: BETA and RC versions should not be used on a live site! No support on upgrading to the final version!

Moderator: And_One

User avatar
zeta65
.
Posts: 965
Joined: Fri Aug 10, 2007 4:40 pm
Location: Italia
Contact:

Another problem about substitution managment

Postby zeta65 » Thu Jan 06, 2011 1:24 am

When I insert a new substitution, close the window and reopen it, I find two lines and not only one.
One is what I saved, the second has no player as coming out and ,as player coming in, it shows the one I have substituited before!.
Can some one confirm this?
here an example
You do not have the required permissions to view the files attached to this post.
website: www.uscosio.org
joomla vers.: Joomla 1.5.x
joomleague vers.:Joomleague 1.5 (latest git build)

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Another problem about substitution managment

Postby timoline » Thu Jan 06, 2011 8:11 am

yes, I thought it was me...

User avatar
zeta65
.
Posts: 965
Joined: Fri Aug 10, 2007 4:40 pm
Location: Italia
Contact:

Re: Another problem about substitution managment

Postby zeta65 » Thu Jan 06, 2011 9:09 am

O.k. before trying to fix it I need some information. now entering one subs we store two records. one with player entered, come_in=1 in_for= player exit and out=0 plus another one with player thet exit with came_in=0 in_for=0 and out=1. Is this the right way? If not this is the bug, if yes the bug is in shpwing inside the substitutions form two record and not only one, hiding the second and deleting it when the first is deleted.. just let me understand how do you want manage substitution.
website: www.uscosio.org
joomla vers.: Joomla 1.5.x
joomleague vers.:Joomleague 1.5 (latest git build)

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Another problem about substitution managment

Postby And_One » Thu Jan 06, 2011 2:51 pm

- storing 2 records is ok
- displaying 2 in the backend substitution players list is not ok

User avatar
zeta65
.
Posts: 965
Joined: Fri Aug 10, 2007 4:40 pm
Location: Italia
Contact:

Re: Another problem about substitution managment

Postby zeta65 » Thu Jan 06, 2011 3:04 pm

And_One wrote:- storing 2 records is ok
- displaying 2 in the backend substitution players list is not ok

Ok, another question:
When you decide to delete a substitution you have to delete two records. Right?
But how the program knows which is the second record to be deleted? just cheking the subs time? or there is anoter way to know which is the second record?
website: www.uscosio.org
joomla vers.: Joomla 1.5.x
joomleague vers.:Joomleague 1.5 (latest git build)

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Another problem about substitution managment

Postby And_One » Thu Jan 06, 2011 4:24 pm

to find a solution pls check how it is saved now:

com_joomleague/administrator/components/com_joomleague/models/match.php

Line ~1203 savesubstitution

or lets discuss on icq?

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Another problem about substitution managment

Postby And_One » Thu Jan 06, 2011 6:11 pm

i found a solution, will commit it soon.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Another problem about substitution managment

Postby And_One » Thu Jan 06, 2011 6:42 pm

fixed and pushed

User avatar
zeta65
.
Posts: 965
Joined: Fri Aug 10, 2007 4:40 pm
Location: Italia
Contact:

Re: Another problem about substitution managment

Postby zeta65 » Thu Jan 06, 2011 11:04 pm

Thanks, I'll try it soon.
website: www.uscosio.org
joomla vers.: Joomla 1.5.x
joomleague vers.:Joomleague 1.5 (latest git build)


Return to “1.5.0-a (Alpha)”

Who is online

Users browsing this forum: No registered users and 4 guests

cron