my last git changes to matchreport view (timeline, roster)

Status: in progress.
This is the Release Candidate 2 for Joomla 1.5 native.

Moderator: And_One

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

my last git changes to matchreport view (timeline, roster)

Postby Heart » Wed Mar 21, 2012 9:18 am

In the matchreport view there are really many possibilities for improvements ;)

Some small changes I did and sent to git the last days. Hope you like.
You do not have the required permissions to view the files attached to this post.

User avatar
tranceRoller
Donator
Donator
Posts: 30
Joined: Wed Sep 21, 2011 9:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby tranceRoller » Wed Mar 21, 2012 9:23 am

Looks good! :whistling:
www.ogres-turnirs.lv -> JoomLeague 1.5.2

User avatar
teddy
.
Posts: 305
Joined: Wed Feb 28, 2007 12:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby teddy » Wed Mar 21, 2012 9:33 am

It look very good!!
And since you are still on fire, why not try to allow people to switch background field from a backend form?

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

Re: my last git changes to matchreport view (timeline, roste

Postby Heart » Wed Mar 21, 2012 9:42 am

teddy wrote:It look very good!!
And since you are still on fire, why not try to allow people to switch background field from a backend form?

This is an option we have to discuss in the future.
Because there are really many sports which could be handled with joomleague ;)

The background could be set with the sportstype used of the project for example. But we/you have to make many background images (one for every sportstype, cutted into two slices top & bottom ;) ).

PS: And I'm not allowed to ship that soccer picture I use in the joomleague package because of licence

User avatar
tranceRoller
Donator
Donator
Posts: 30
Joined: Wed Sep 21, 2011 9:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby tranceRoller » Wed Mar 21, 2012 11:11 am

But we/you have to make many background images

Can help with it.
Need:
1) list of sports types
2) image specification
www.ogres-turnirs.lv -> JoomLeague 1.5.2

User avatar
teddy
.
Posts: 305
Joined: Wed Feb 28, 2007 12:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby teddy » Wed Mar 21, 2012 11:41 am

I can help as well, let me know.
About the timeline, is it possible to show events displayed one after the other for leagues where timing of events isn't given? Or does it already happen?

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

Re: my last git changes to matchreport view (timeline, roste

Postby Heart » Wed Mar 21, 2012 11:57 am

teddy wrote:I can help as well, let me know.
About the timeline, is it possible to show events displayed one after the other for leagues where timing of events isn't given? Or does it already happen?

Hm, the time you set in your project is taken as 100% ("Regular playing time") in the timeline and every event of a match is displayed proportionable there when it happened.

So if you have a regular playing time of 100 minutes and have an event saved at minute 10 this event is shown on place 10% of that line.

So I think if you don't save a minute when adding an event that will be a problem :confused:

User avatar
Atletic Rodenc
.
Posts: 313
Joined: Mon Feb 15, 2010 10:28 am
Joomleague version: 2.0.x
Location: Roda de Ter
Contact:

Re: my last git changes to matchreport view (timeline, roste

Postby Atletic Rodenc » Wed Mar 21, 2012 1:55 pm

Looks good !!!

But I update my joomleague with the last git and don't see this options ....

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

Re: my last git changes to matchreport view (timeline, roste

Postby Heart » Wed Mar 21, 2012 2:02 pm

@Atletic Merge Request still open. And_One wasn't online today until now. He has to commit it and then fetch jl from git again and you'll have the new options.

User avatar
Atletic Rodenc
.
Posts: 313
Joined: Mon Feb 15, 2010 10:28 am
Joomleague version: 2.0.x
Location: Roda de Ter
Contact:

Re: my last git changes to matchreport view (timeline, roste

Postby Atletic Rodenc » Wed Mar 21, 2012 2:10 pm

Heart wrote:@Atletic Merge Request still open. And_One wasn't online today until now. He has to commit it and then fetch jl from git again and you'll have the new options.


Thanks a lot for you quickly answer !!

User avatar
comraden
Joomleague Core Developer
Joomleague Core Developer
Posts: 1291
Joined: Thu Aug 16, 2007 2:27 pm
Location: Poland, Lublin
Contact:

Re: my last git changes to matchreport view (timeline, roste

Postby comraden » Wed Mar 21, 2012 2:13 pm

merged, thx
http://llk.pl::jl_1.6 | jl_2.x | jl_3.x testing/production enviroment
samiec alfa koncernu 'Cham_Burak_Prostak' || proved: the most annoying person on the forum

User avatar
teddy
.
Posts: 305
Joined: Wed Feb 28, 2007 12:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby teddy » Wed Mar 21, 2012 7:54 pm

Heart wrote:So I think if you don't save a minute when adding an event that will be a problem :confused:


Couldn't it be put in place in a proportional way? Say, timeline 800px long, divided by n events means n px. The events could be displayed every n pixels, couldn't they?
Please take it as a suggestion, not more, just because lots of amateur tournaments are very rarely provided with timing for events (maybe goals are given, but cards almost never)...

Heart
Joomleague Core Developer
Joomleague Core Developer
Posts: 653
Joined: Fri Apr 23, 2010 10:27 am

Re: my last git changes to matchreport view (timeline, roste

Postby Heart » Thu Mar 22, 2012 11:11 am

Ahhm, a timeline is for visualize timed events, isn't it!?
So it doesn't make sense for me to only show a list of events (which hasn't any time) next to each other!!? This is not the concept of a timeline, is it?! :confused:

User avatar
teddy
.
Posts: 305
Joined: Wed Feb 28, 2007 12:01 pm

Re: my last git changes to matchreport view (timeline, roste

Postby teddy » Thu Mar 22, 2012 11:29 am

You are definitely right in a theoretical point of view, but very often happens that only goal timings are provided, and it's very nice to display them on the timeline.
But what happens with cards, that are not given with time? Is there a way to show an event type and not another?

User avatar
TAPS
Donator
Donator
Posts: 11
Joined: Wed Feb 28, 2007 11:55 pm
Joomleague version: 2.0.x
Contact:

Re: my last git changes to matchreport view (timeline, roste

Postby TAPS » Thu Mar 22, 2012 12:51 pm

And if only events are displayed on the timeline, have a time value?


Return to “1.5.5-amber (RC 2)”

Who is online

Users browsing this forum: No registered users and 1 guest

cron