"Games history" missing in Player page

Status: in progress.
This is the Release Candidate 2 for Joomla 1.5 native.

Moderator: And_One

hansnix
Donator
Donator
Posts: 57
Joined: Sat Oct 29, 2011 9:16 pm

"Games history" missing in Player page

Postby hansnix » Sat Mar 10, 2012 9:41 pm

Hi,

After updating to 1.5.5 I do not see the "Game history" for the player.
I do see "Personal statistics" and "Playing career" but not the "Games history" which I saw in 1.5.4.

I did not change the "Player page Frontend-Settings". It is still set to "yes" for "show projects's games".

I see a lot of changes here. So I am not sure if it is a bug or if I have missed the appropriate setting.

Hans

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: "Games history" missing in Player page

Postby timoline » Sat Mar 10, 2012 9:52 pm

its missing for all players?
if so, you can try to reset the frontend settings Player, so it gets the default values
Joomla 1.5.x
Joomleague 1.5.....latest git version

hansnix
Donator
Donator
Posts: 57
Joined: Sat Oct 29, 2011 9:16 pm

Re: "Games history" missing in Player page

Postby hansnix » Sat Mar 10, 2012 10:18 pm

It is missing for all players.

A reset doesn't change the behaviour. The "Game history" for the player.
If someone sees the same problem, then I will submit a bug report.

Hans.

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: "Games history" missing in Player page

Postby timoline » Sat Mar 10, 2012 11:04 pm

I dont have this "bug" ....
CHecked on a few (test) websites
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
tranceRoller
Donator
Donator
Posts: 30
Joined: Wed Sep 21, 2011 9:01 pm

Re: "Games history" missing in Player page

Postby tranceRoller » Sun Mar 11, 2012 11:26 am

"Games history" still working on 1.5.5 to me.
www.ogres-turnirs.lv -> JoomLeague 1.5.2

hansnix
Donator
Donator
Posts: 57
Joined: Sat Oct 29, 2011 9:16 pm

Re: "Games history" missing in Player page

Postby hansnix » Sun Mar 11, 2012 1:19 pm

Hm,

I entered some echo statements into some files and I could see that in

<joomla>\components\com_joomleague\views\player\tmpl\default_gameshistory.php

an "echo count($this->games);" shows "0". Now it is obvious why the history data isn't shown. But why doesn't the system see any numbers of games?
So I checked the file:

<joomla>\components\com_joomleague\models\player.php

and added an "echo $query;" in the function getGames(). Here I could see that the system uses an incorrect DB table prefix! For example it tries to use "jos_joomleague_match" instead of "joomla3_joomleague_match".
I checked in Site > configuration > Server > Database > databaseprefix > and here I do see the correct value "joomla3_".

So I checked the source in GIT for player.php and it looks that it is entered fixed in the code for the function getGames() like (line 586):

$common_query_part = ' INNER JOIN jos_joomleague_match AS m ON m.id = md.match_id '

instead of:

$common_query_part = ' INNER JOIN #__joomleague_match AS m ON m.id = md.match_id '
...


I am a little bit wondering because in the past I used the same prefix "jos_" for my installation. Maybe this is coincidence or a made something wrong.


Is someone able to double check that because I am not that familiar with GIT?

Hans

hansnix
Donator
Donator
Posts: 57
Joined: Sat Oct 29, 2011 9:16 pm

Re: "Games history" missing in Player page

Postby hansnix » Sun Mar 11, 2012 2:01 pm

I just changed all "jos_" to "#__" in player.php of my installation and the Games history is back now!

If someone can confirm that this is a bug I would like to take this Bugfix as my first contribution to the Joomleague software. What is the procedure?

First create a bug in Bugtraker and wait until I get assigned to it?
Then fix the code in my local repository on my personal PC.
Then right click on "player.php" in the Explorer and click on "Git commit > master ..."?

Hans

Please excuse my "beginner" questions.

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: "Games history" missing in Player page

Postby timoline » Sun Mar 11, 2012 3:38 pm

I will have a look at it, tonight. Thx
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: "Games history" missing in Player page

Postby timoline » Sun Mar 11, 2012 4:48 pm

jos is de klos,

Good bugtracking :thx:

commited in GIT;)
Joomla 1.5.x
Joomleague 1.5.....latest git version

hansnix
Donator
Donator
Posts: 57
Joined: Sat Oct 29, 2011 9:16 pm

Re: "Games history" missing in Player page

Postby hansnix » Sun Mar 11, 2012 6:03 pm

Hm,

I wanted to fix and upload it to GIT!

Just to tell my grand children in a couple of decades:

"I made contributions to the code of Joomleague!"

Maybe next time I will just do it.

Hans.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3612
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: "Games history" missing in Player page

Postby And_One » Sun Mar 11, 2012 6:45 pm

follow the wiki instructions on gitorious

BorussenTV
.
Posts: 37
Joined: Thu May 13, 2010 2:08 am

Re: "Games history" missing in Player page

Postby BorussenTV » Sun Mar 11, 2012 7:04 pm

:thx:

I started upgrading today and I thought I had some wrong settings, but i couldn't get the player statstics. Because we use joomleague also for our android app (with some hacks for mobile site) that was really important for us to get it to work. Thanks for solving the problem.
Joomla Version: 2.5.6
Joomleague Version: JoomLeague - v2.0.0.6e524f0
Website: http://www.Borussen.tv

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: "Games history" missing in Player page

Postby timoline » Sun Mar 11, 2012 8:50 pm

hansnix wrote:Hm,

I wanted to fix and upload it to GIT!

Just to tell my grand children in a couple of decades:

"I made contributions to the code of Joomleague!"

Maybe next time I will just do it.

Hans.

:cool:
Joomla 1.5.x
Joomleague 1.5.....latest git version


Return to “1.5.5-amber (RC 2)”

Who is online

Users browsing this forum: No registered users and 3 guests

cron