Suggestion for mod_joomleague_results

Status: finished.
This is a bugfix release with a limited set of new features.

Moderator: And_One

User avatar
Lord_Helmchen
.
Posts: 45
Joined: Fri Aug 03, 2007 1:56 pm
Joomleague version: 2.0.x
Location: Germany
Contact:

Suggestion for mod_joomleague_results

Postby Lord_Helmchen » Fri Dec 02, 2011 5:59 pm

For better XHTML compatibility the stylesheet should be in the header and should use class instead id. Here is my changed modules/mod_joomleague_results/tmpl/default.php
default.zip
You do not have the required permissions to view the files attached to this post.

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Suggestion for mod_joomleague_results

Postby timoline » Fri Dec 02, 2011 7:18 pm

Best thing to do is to do this in GIT of course
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
Lord_Helmchen
.
Posts: 45
Joined: Fri Aug 03, 2007 1:56 pm
Joomleague version: 2.0.x
Location: Germany
Contact:

Re: Suggestion for mod_joomleague_results

Postby Lord_Helmchen » Fri Dec 02, 2011 7:27 pm

I don't know GIT and i don't use GIT. So maybe you can do it in GIT? :confused:

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3612
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Suggestion for mod_joomleague_results

Postby And_One » Sun Dec 04, 2011 7:52 pm

can i see the module code in action? live link?

User avatar
Lord_Helmchen
.
Posts: 45
Joined: Fri Aug 03, 2007 1:56 pm
Joomleague version: 2.0.x
Location: Germany
Contact:

Re: Suggestion for mod_joomleague_results

Postby Lord_Helmchen » Mon Dec 05, 2011 12:22 pm

Here is the module http://www.evr-fans.de/

I've tested the site with validator.w3c.org. All errors related with the module are gone.

User avatar
kubik
.
Posts: 618
Joined: Tue Nov 03, 2009 7:20 pm
Joomleague version: 2.0.x
Location: Oberschlesien
Contact:

Re: Suggestion for mod_joomleague_results

Postby kubik » Mon Dec 05, 2011 9:16 pm

Lord_Helmchen wrote:Here is the module http://www.evr-fans.de/

I've tested the site with validator.w3c.org. All errors related with the module are gone.

I dont see any difference, could you show us what did you change? :confused:
Joomla 2.5.x & 3.x
JoomLeague - Latest Git Version
GG Network No : 5739578
www.RegioLiga.pl

User avatar
Lord_Helmchen
.
Posts: 45
Joined: Fri Aug 03, 2007 1:56 pm
Joomleague version: 2.0.x
Location: Germany
Contact:

Re: Suggestion for mod_joomleague_results

Postby Lord_Helmchen » Tue Dec 06, 2011 10:51 am

As i wrote in my first post. Stylesheet between <header></header>, not in body anymore. And CSS use classes instead of id. e.g. now <span class="mod_jl_results_matchwin"> before <span id="mod_jl_results_matchwin">

That makes the module XHTML compatible.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3612
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Suggestion for mod_joomleague_results

Postby And_One » Thu Dec 08, 2011 10:49 pm

thx commited!


Return to “1.5.3-karina (Beta 3)”

Who is online

Users browsing this forum: No registered users and 3 guests