complete dfb-key tool packages

Extensions / Customization for JoomLeague 1.6.
User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

complete dfb-key tool packages

Postby diddipoeler » Wed Apr 28, 2010 7:20 pm

hallo,

@timoline @kurt

i write it fast in german:

hoffentlich habe ich da keine fehler gemacht. habe alle datein für das dfbkey tool gepusht. kann aber kein merge request stellen.

hab ich was falsch gemacht?

wenn nicht, könnt ihr das tool jetzt testen.

gruss diddipoeler
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

antiheld
.
Posts: 119
Joined: Thu Apr 19, 2007 5:16 pm

Re:complete dfb-key tool packages

Postby antiheld » Wed Apr 28, 2010 7:23 pm

hi,
EDIT: scheint doch im master drin zu sein.
ich spiels mal auf und teste es!
gruss
Last edited by antiheld on Wed Apr 28, 2010 7:31 pm, edited 1 time in total.
joomla 1.5.17
joomleague  0.93b lokal; eigene version basierend auf 1.5 svn; latest git mit overrides
seite nur aus dem vpn der rwth aachen erreichbar

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re:complete dfb-key tool packages

Postby timoline » Thu Apr 29, 2010 9:18 am

Still I do not agree this will be included in joomleague, because its a "german-only" thing!

And you (I think) accidently pushed it into the master.....please only push to your clone :thx:
Last edited by timoline on Thu Apr 29, 2010 9:26 am, edited 1 time in total.
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Thu Apr 29, 2010 10:22 am

timoline wrote:Still I do not agree this will be included in joomleague, because its a "german-only" thing!


please discusses this with @kurt  :thx:

timoline wrote:And you (I think) accidently pushed it into the master.....please only push to your clone :thx:


this was my bug yesterday  :(
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

User avatar
julienV
Joomleague Core Developer
Joomleague Core Developer
Posts: 2016
Joined: Tue Jun 19, 2007 9:27 am
Location: France
Contact:

Re:complete dfb-key tool packages

Postby julienV » Thu Apr 29, 2010 4:10 pm

i reverted it.

I am not sure what this code does, and how it works, but maybe you could find a way to rather integrate it in a plugin, or in a dependant component, so that it can be installed by only thos who need it.
You can hire me, I'm a Joomla professional freelance developer.
Please contact me at jlv@jlv-solutions.com
NO PM, please use email !

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re:complete dfb-key tool packages

Postby And_One » Thu Apr 29, 2010 5:16 pm

we have no interface for extensions which can add menulinks to our main navigation. i think we have to discuss this or what do you think how an extension can add a simple link to the joomleague menu?
Joomla 1.5.x
Joomleague 1.6 Final
Working on Joomleague 2.0
[url=http://forum.joomleague.net/viewforum.php?f=109]Joomleague 1.6 Extended Data Editor[/url]
[url=https://opentranslators.transifex.com]
[img]https://ds0k0en9abmn1.cloudfront.net/static/widgets/images/transifex-userbar.1d82cbde2ade.png[/img]
[/url]

User avatar
julienV
Joomleague Core Developer
Joomleague Core Developer
Posts: 2016
Joined: Tue Jun 19, 2007 9:27 am
Location: France
Contact:

Re:complete dfb-key tool packages

Postby julienV » Thu Apr 29, 2010 5:31 pm

i don't know, but my point is that joomleague is not just about football, not to say german first league football
You can hire me, I'm a Joomla professional freelance developer.
Please contact me at jlv@jlv-solutions.com
NO PM, please use email !

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re:complete dfb-key tool packages

Postby And_One » Thu Apr 29, 2010 5:34 pm

julienV wrote:i don't know, but my point is that joomleague is not just about football, not to say german first league football


agree, but we need to provide at least a menu interface that a possible extension developer can use to add his own links without hacking core files
Joomla 1.5.x
Joomleague 1.6 Final
Working on Joomleague 2.0
[url=http://forum.joomleague.net/viewforum.php?f=109]Joomleague 1.6 Extended Data Editor[/url]
[url=https://opentranslators.transifex.com]
[img]https://ds0k0en9abmn1.cloudfront.net/static/widgets/images/transifex-userbar.1d82cbde2ade.png[/img]
[/url]

User avatar
julienV
Joomleague Core Developer
Joomleague Core Developer
Posts: 2016
Joined: Tue Jun 19, 2007 9:27 am
Location: France
Contact:

Re:complete dfb-key tool packages

Postby julienV » Thu Apr 29, 2010 5:37 pm

if it is a extra component, it can have it's own links
You can hire me, I'm a Joomla professional freelance developer.
Please contact me at jlv@jlv-solutions.com
NO PM, please use email !

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Thu Apr 29, 2010 7:52 pm

hallo,

first step: this tool is not for football it´s for soccer.
i say it in german, because it´s better for me.

hier ist der link zum schlüssel, der alles beschreibt: http://www.dfbnet.org/downloads/Eigenschaften_L1-Spielschluessel.pdf
hier ist die zuordnung der spieltage zu den paarungen: http://www.dfbnet.org/downloads/SZ_1-L.pdf

so wie ich das thema mit @kurt diskutiert habe, war dieses tool ein wunsch mehrerer 100 usern. ausserdem ist das tool vom
dfb anerkannt und für mehrer 1000 ligen maßgebend.

die frage die ich mir stelle ist diese: wer ist projektleiter und entscheidet was in joomleague integriert wird ?

es kann nicht sein, das etwas nicht implementiert wird, weil es ein entwickler nicht kennt. das ist jetzt auch nicht böse gemeint.
ich arbeite immer noch an den bugs von joomleague weiter und versuche diese auch so schnell wie möglich zu bereinigen. den bug
im modul: mod_joomleague_nextmatch_ext habe ich gefunden und gerade an´s git gepushed.

gruss diddipoeler
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

antiheld
.
Posts: 119
Joined: Thu Apr 19, 2007 5:16 pm

Re:complete dfb-key tool packages

Postby antiheld » Thu Apr 29, 2010 8:15 pm

i am also a supporter of dfb keys in joomleague!
its a great feature and people who dont need it can just ignore that part. furthermore people from contries outside germany can use it as a quick way for match creation.
joomla 1.5.17
joomleague  0.93b lokal; eigene version basierend auf 1.5 svn; latest git mit overrides
seite nur aus dem vpn der rwth aachen erreichbar

User avatar
johncage
.
Posts: 953
Joined: Fri May 11, 2007 11:49 pm
Location: Somewhere under the rainbow
Contact:

Re:complete dfb-key tool packages

Postby johncage » Thu Apr 29, 2010 8:23 pm

you all really are kind of strange, aren't you?

who the hell are YOU all to decide what community is provided with and what it is not???

it is for german leagues only and soccer only, so what?
nobody's hurt by implementing dfb-key tool package if it works...

be glad at least some people still help you with your decades lasting questionable way of all time testing development...
Look, you've got it all wrong! You don't NEED to follow ME, You don't NEED to follow ANYBODY! You've got to think for your selves! You're ALL individuals!
So keep a clear head and always carry a lightbulb.

User avatar
julienV
Joomleague Core Developer
Joomleague Core Developer
Posts: 2016
Joined: Tue Jun 19, 2007 9:27 am
Location: France
Contact:

Re:complete dfb-key tool packages

Postby julienV » Thu Apr 29, 2010 9:05 pm

of course it's good, but it's better if it can be integrated separately... Nevermind, if you want it in, just put it in, but try not to make it too interlaced with the general code, if that is possible.
You can hire me, I'm a Joomla professional freelance developer.
Please contact me at jlv@jlv-solutions.com
NO PM, please use email !

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re:complete dfb-key tool packages

Postby timoline » Fri Apr 30, 2010 8:09 am

calm down johncage,
its just a discussion, nothing more nothing less.
as always....there are pros and cons, and finally there will be an agreement. :)
Why getting so furious about it?
Some have other opinions how to implement this, there is nothing wrong about that...
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Fri Apr 30, 2010 10:14 am

hallo,

ich glaube die lösung ist ganz einfach. man legt eine neue tabelle mit dem namen: jos_joomleague_addons an (bild 1).

in der datei view.html.php im verzeichnis administrator/components/com_joomleague/view/adminmenu
fügt man diese zeilen ein:

Code: Select all


// start addons
/*
* read addons
*/

    $linkaddon = array();
      $labeladdon = array();
      $limageaddon = array();

      $pane = new stdClass();
      $pane->title = 'User-AddOns';
      $pane->name = 'AOMenu';
      $pane->alert = false;
      $tabs[] = $pane;

$query = '   SELECT   *
               FROM #__joomleague_addons
               ORDER BY name ';

      $db->setQuery( $query );
    $result = $db->loadObjectList();    
       
foreach($result as $res)
            {
            $linkaddon[]  = JRoute::_( 'index.php?option=com_joomleague&view='.$res->view.'&controller='.$res->controller );
      $labeladdon[] = $res->name;
      $limageaddon[] = JHTML::_( 'image', $imagePath . $res->image , JText::_( $res->text ) );   
            }           
      
    $link[]  = $linkaddon;
      $label[] = $labeladdon;
      $limage[] = $limageaddon;
    
// end addons


wenn nun ein neues packages über das backend installiert wurde erscheint es im menü: user-addons (bild 2).

jetzt könnte ich das dfb-key tool als package vorbereiten und wenn man es dann installiert erscheint es
auch im neuen menü. so könnte man auch den lmo-import vorbereiten.

gruss diddipoeler

ps: das installationspaket habe ich auch so ebend fertiggestellt  :)
You do not have the required permissions to view the files attached to this post.
Last edited by diddipoeler on Fri Apr 30, 2010 12:02 pm, edited 1 time in total.
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Fri Apr 30, 2010 12:13 pm

hallo,

package is ready and it works  ;)

greats diddipoeler
You do not have the required permissions to view the files attached to this post.
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re:complete dfb-key tool packages

Postby timoline » Fri Apr 30, 2010 12:21 pm

:) good work

I think you can push this into the plugin folder or 3rd party folder of your personal clone and do a merge request
Joomla 1.5.x
Joomleague 1.5.....latest git version

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Fri Apr 30, 2010 12:29 pm

timoline wrote: :) good work

I think you can push this into the plugin folder or 3rd party folder of your personal clone and do a merge request


hallo,

i have change the file view.html.php in the directory administrator/components/com_joomleague/view/adminmenu

can i push this on my clone and then create a merge request for the master ?
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re:complete dfb-key tool packages

Postby And_One » Fri Apr 30, 2010 12:38 pm

some comments:

- pls add a text resouce for the "User-Addons" menu link.
- where are the "addons" files physically stored?
Joomla 1.5.x
Joomleague 1.6 Final
Working on Joomleague 2.0
[url=http://forum.joomleague.net/viewforum.php?f=109]Joomleague 1.6 Extended Data Editor[/url]
[url=https://opentranslators.transifex.com]
[img]https://ds0k0en9abmn1.cloudfront.net/static/widgets/images/transifex-userbar.1d82cbde2ade.png[/img]
[/url]

User avatar
diddipoeler
.
Posts: 1151
Joined: Sun Feb 04, 2007 3:29 pm
Joomleague version: 2.0.x
Contact:

Re:complete dfb-key tool packages

Postby diddipoeler » Fri Apr 30, 2010 12:40 pm

And_One wrote:some comments:

- pls add a text resouce for the "User-Addons" menu link.
- where are the "addons" files physically stored?


verstehe ich jetzt gerade nicht !

die files werden in die selbe struktur, wie die files bei einer joomleague installation, kopiert.
You do not have the required permissions to view the files attached to this post.
über 8 Mio. Spielpaarungen auf http://www.laola-fussball-international.de/
über 8 Mio. Spielpaarungen auf http://www.**************.de/
Joomlaversion: 1.5.26
Testserver mit Joomleague Version 0.93
Tippspieltestseite: http://joomleague16.**************/
Das Komplettpaket: https://github.com/diddipoeler/joomleague-komplett
Das Komplettpaket 2.0: https://github.com/diddipoeler/joomleague-2-komplettpaket

User avatar
mindh4nt3r
Joomleague Core Developer
Joomleague Core Developer
Posts: 125
Joined: Fri Apr 02, 2010 4:22 pm
Joomleague version: 2.0.x
Contact:

Re: complete dfb-key tool packages

Postby mindh4nt3r » Sat Aug 07, 2010 2:49 pm

Guys, I'm kinda wondering why we still have all the dfb files and code inside the current build.

From what I know we have agreed to exclude it and offer it as an extension of some kind.

Can someone please give me a status update on this because by the looks of it, nothing is being done about it.

User avatar
Kurt
Donator
Donator
Posts: 932
Joined: Mon Mar 19, 2007 7:40 pm
Location: Germany
Contact:

Re: complete dfb-key tool packages

Postby Kurt » Sun Aug 08, 2010 4:23 am

mindh4nt3r wrote:Guys, I'm kinda wondering why we still have all the dfb files and code inside the current build.

From what I know we have agreed to exclude it and offer it as an extension of some kind.

Can someone please give me a status update on this because by the looks of it, nothing is being done about it.


I don't like something like "as an extension kind of some kind". What kind of extension??? How to add any extension to JL at the moment??? I haven't seen that such a system of adding an extension exists and is working actually.

So please don't delete something existing as long as we have not a better idea. It is there, doesn't cost any money. So please just leave it as long as it doesn't make any problems.

User avatar
mindh4nt3r
Joomleague Core Developer
Joomleague Core Developer
Posts: 125
Joined: Fri Apr 02, 2010 4:22 pm
Joomleague version: 2.0.x
Contact:

Re: complete dfb-key tool packages

Postby mindh4nt3r » Sun Aug 08, 2010 9:56 pm

It could be made into a module.

Look the biggest problem I have with it that we now have 1 of these things that only is there for the germans and even then there is just a small group of users who would use it.

What would you think if i would made a specific function for the dutch KNVB Sunday Cup matches. Only like 1 % of the joomleague users would use this but because we dont have an extension system in place everyone would have these database tables in place, have more code in place which is not used and it all just becomes a big cluther.

I just feel that we should somehow create a joomleague extension system so we can avoid these problems.

I will place the dfb tables back in the sql files but I still feel this will have to be dealt with. Another thing is that the code is there.. but it is not functional at the moment so I'm kinda questioning why it is there?

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: complete dfb-key tool packages

Postby And_One » Sun Aug 08, 2010 10:20 pm

To build joomleague 1.5 extensions is already possible, but the disadanvatage is that an extension points to a specific project. so i think the extension system needs to be extended that its possible to load an extension if the extension is global like the dfb-key tool. and we need a hook in our adminmenu, so that an extension can add its own menu categories and links. i dont like the intended user addon system because the custom code would be mixed with the joomleague core code base. i want to have the custom files in a separate directory and therefor the extension system is perfect.

antiheld
.
Posts: 119
Joined: Thu Apr 19, 2007 5:16 pm

Re: complete dfb-key tool packages

Postby antiheld » Sun Aug 08, 2010 10:23 pm

hello,
imho your both right.
deleting that code would be wrong, but right now its useless.
a plugin system is a huge amount of work. this should not have 1st priority. i suggest you deal with that later. as long as its not functional there is no point of keeping dfbkeys in the installer, but a few people should have good backups.

regards

User avatar
mindh4nt3r
Joomleague Core Developer
Joomleague Core Developer
Posts: 125
Joined: Fri Apr 02, 2010 4:22 pm
Joomleague version: 2.0.x
Contact:

Re: complete dfb-key tool packages

Postby mindh4nt3r » Sun Aug 08, 2010 10:25 pm

That is great to hear the extension system is in place already.. From what I see is that you should assign the dfb tool to a specific project anyways because there is a a chance that you are keeping track of different competitions.

Anyways, my biggest concern was just like yours that extension code is hard-coded into the joomleague core as it is being done right now. Like the dfb tables and the code that is inside the admin-menu right now. We could take care of this in several manners, but I'm kinda wondering what diddi thinks and since it is his extension and he know the ins and the outs of the code it might be better he takes care of it.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: complete dfb-key tool packages

Postby And_One » Sun Aug 08, 2010 10:28 pm

its not very hard to extend the com_joomleague/components/com_joomleague/joomleague.php to load extensions by the filesystem and not by the project. maybe we should do it the other way round and select inside the project which of the available extensions should not be loaded.

User avatar
mindh4nt3r
Joomleague Core Developer
Joomleague Core Developer
Posts: 125
Joined: Fri Apr 02, 2010 4:22 pm
Joomleague version: 2.0.x
Contact:

Re: complete dfb-key tool packages

Postby mindh4nt3r » Sun Aug 08, 2010 10:33 pm

Good suggestion.. lets put a multi-list in there with the available extensions so you can sellect them per project. Do you have any insight in how this system is working currently?

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: complete dfb-key tool packages

Postby And_One » Sun Aug 08, 2010 10:35 pm

it is described here: viewtopic.php?f=13&t=10104

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: complete dfb-key tool packages

Postby timoline » Tue Jan 11, 2011 11:53 am

Hmm what happened with this discussion?

It went from addon to extensions :)

Lets discuss it further,
We really should have some kind of addon/plugin system for Import scripts like
-dfbkeys
-LMO
-Joomsport
-professional league
-etc...

I prefer, all these import scripts should have a standalone installer.
So if you want LMO import; install it in Joomla and you have a LMO-importer for Joomleague,
If you want DFBkeys importer, install it in Joomla and you can use DFBkeys for Joomleague, etc...

What do you think?

p.s.
Diddi's idea is really not a bad idea, if correct implemented :)
viewtopic.php?p=50276#p50276


Return to “Extensions / Customizations”

Who is online

Users browsing this forum: No registered users and 1 guest