Problem with Player pictures and IE

Status: finished.
This is a bugfix release with a limited set of new features.

Moderator: And_One

Sofia
Newbie
Posts: 5
Joined: Sat Jan 29, 2011 2:25 pm

Problem with Player pictures and IE

Postby Sofia » Sun Apr 17, 2011 9:02 pm

Hi

Most of the time I use the search function to find the answers to nearly anything. Thanks to all who are contributing!

However... This time I'm clueless even after multiple searches. Since a recent update (and no, sorry but I have absolutely no idea which one) our player pictures don't show in the player profiles anymore. It seems to work just fine with other browsers but not with IE.

http://www.kulladalsff.com/index.php?option=com_joomleague&view=player&p=1&tid=1&pid=335&Itemid=798

There are a lot of things on the site that's a little weird right now, I know. There's a lot of work to be done but this is the one that's bugging me.

No, IE isn't God's gift to mankind but since 73% of our visitors use it (it's still the most used browser in Sweden), it kinda has to work...

We use Joomla 1.5.23 and JL v1.5.1.8d2f261.
(Btw, our "Powered by JoomLeague" seems to have disappeared but I can't find the option in FES anymore?)

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Sun Apr 17, 2011 9:52 pm

Thats of course correct. i have pushed a fix. try now.

Sofia
Newbie
Posts: 5
Joined: Sat Jan 29, 2011 2:25 pm

Re: Problem with Player pictures and IE

Postby Sofia » Sun Apr 17, 2011 11:11 pm

Powered by is back. Now there's only my main problem...

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Sun Apr 17, 2011 11:16 pm

Sofia wrote:Powered by is back. Now there's only my main problem...


fixed here https://gitorious.org/joomleague/joomle ... 8e30fc8248

Sofia
Newbie
Posts: 5
Joined: Sat Jan 29, 2011 2:25 pm

Re: Problem with Player pictures and IE

Postby Sofia » Sun Apr 17, 2011 11:22 pm

Thank you! This has been driving me crazy. Found something about png/jpg in one om my searches but got it all wrong in the files. Again, thank you!

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Sun Apr 17, 2011 11:59 pm

Sofia wrote:Thank you! This has been driving me crazy. Found something about png/jpg in one om my searches but got it all wrong in the files. Again, thank you!


your are welcome!

stothez84
Newbie
Posts: 12
Joined: Tue Apr 05, 2011 11:59 am
Joomleague version: 0.93x

Re: Problem with Player pictures and IE

Postby stothez84 » Tue Apr 19, 2011 11:01 am

I've got the same problem and want to fix this now.. i'm really new at joomleague and I don't know really what should I do with this link and the code text? Could anybody give me a short hint what i have to do? :)

Thanks & Regards
stothez

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Wed May 04, 2011 5:29 pm

Very new to Joomla and JL so please be kind.

I think I have the same issue with my large club logos not being displayed on the front end for match reports and club details - http://btfc-joomla-2.pdsupport.net/joom ... &mid=2&p=1

The medium and small logos appear to work fine.

All images are .PNG.

I've gone to the fix posted above and presumably red is to remove and green to insert, however my copy of the file jlcommon.php appears up to date, although I notice it includes a few extra lines to that in the fix:

if (!empty($picture))
{
$PhpThumbFactory::create($picture);
$params = JComponentHelper::getParams('com_joomleague');

$format = "JPG"; //PNG is not working in IE8
$format = $params->get('thumbformat', 'PNG');
$thumb->setFormat($format);

//height and width set, resize it with the thumblib
if($height>0 && $width>0) {


I'm running Joomla 1.5.23 and JoomLeague - v1.5.1.cd46bb5.

PLEASE HELP...

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Wed May 04, 2011 9:13 pm

No responses so I've dug a bit deeper and I can see that this was apparently fixed by "And_One" 3 days ago so I've replaced the following updated files:
config.xml (diff)
jlcommon.php (diff)
en-GB.com_joomleague.ini (diff)

This doesn't seem to have fixed the problem, what am I doing wrong?

Please advise if you know...

Thanks.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Wed May 04, 2011 9:15 pm

Which Browser?

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Wed May 04, 2011 9:17 pm

Hi And_One - thanks for the response.

I'm using IE7

My mate says the images display fine in IE9

Does this mean it doesn't work in this version and as such is an accepted bug?

If that's the case is there a recommended workaround?

Thanks

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Wed May 04, 2011 10:32 pm

cookiebtfc wrote:Hi And_One - thanks for the response.

I'm using IE7

My mate says the images display fine in IE9

Does this mean it doesn't work in this version and as such is an accepted bug?

If that's the case is there a recommended workaround?

Thanks


Google: ie7 png fix

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Wed May 04, 2011 10:52 pm

Why does IE7 not have any problem displaying the other PNG images on the site and in JL?

Thanks.

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Thu May 05, 2011 8:38 am

I've now converted my club logo large into a .gif image and updated the 'Thumb Image Format' in 'Global Setting Frontend' to "GIF" and the images still do not display in IE7.

Can somebody tell me the impact of switching to 0.93 and activating the joomla plugin to run in legacy mode as it seems 1.5.1 simply doesn't work properly for the logo large on IE8 or below which unfortunately most people are still using??? See example of PNG images displaying fine in 0.963 - http://www.tauntonrfc.co.uk/match-info/ ... -201011/56

Or

Can anybody show me a site using 1.5.1 where it is working (displaying the large logos) and explain what I am doing wrong??

Thanks

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Problem with Player pictures and IE

Postby timoline » Thu May 05, 2011 10:37 am

its a stupid IE8 bug
Joomla 1.5.x
Joomleague 1.5.....latest git version

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Thu May 05, 2011 7:31 pm

Hi Timeoline - Okay but is there a workaround for 1.5.1 and if so please can you explain it as I'd loath to go to a legacy version.

Thanks.

dtexic
Newbie
Posts: 9
Joined: Mon Jan 31, 2011 1:02 am
Location: Czech rep.
Contact:

Re: Problem with Player pictures and IE

Postby dtexic » Thu May 05, 2011 8:27 pm

Hi,
I´ve similar problem with Firefox 4. I made a large club logo in PNG with transparent backgroung and in the frontend is with black background. The same PNG as small and middle logo has transparent background as I want.

M.

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Problem with Player pictures and IE

Postby timoline » Thu May 05, 2011 8:29 pm

cookiebtfc wrote:Hi Timeoline - Okay but is there a workaround for 1.5.1 and if so please can you explain it as I'd loath to go to a legacy version.

Thanks.


sorry not yet...
Joomla 1.5.x
Joomleague 1.5.....latest git version

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Thu May 05, 2011 8:44 pm

you will have only a problem if you want a resized image. use FS 0 0 and you will geht the original uploaded picture. check the ticket comments.

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Thu May 05, 2011 8:47 pm

Thanks, I'll check the ticket comments now as my images are sized at 150 x 150 which is what the required size was so not sure why it would be resizing them.

Thanks again.

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Thu May 05, 2011 9:09 pm

Sorry, what is "FS 0 0 "

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Thu May 05, 2011 9:40 pm

cookiebtfc wrote:Sorry, what is "FS 0 0 "


if height and width set, resize it with the thumblib
if height==0 and width set, let the browser resize it
if width==0 and height set, let the browser resize it
if width==0 and height==0, use original picture size

http://bugtracker.joomleague.at/redmine/issues/728

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Thu May 05, 2011 10:29 pm

I give up now as I've checked every 1.5.1 website that there has been a link for (in IE7) and nobody has managed to display their large logo, despite all the advise and suggested fixes.

http://btfc-joomla-2.pdsupport.net/joom ... &Itemid=13

http://sportowa.zgora.pl/component/joom ... /1019.html

http://www.kulladalsff.com/index.php?op ... Itemid=798

Looks like a step backwards to 0.93 is in order which is a shame.

And_One
Joomleague Project Manager, Donator
Joomleague Project Manager, Donator
Posts: 3609
Joined: Fri Sep 11, 2009 4:00 pm
Joomleague version: 2.0.x
Location: Graz
Contact:

Re: Problem with Player pictures and IE

Postby And_One » Fri May 06, 2011 10:22 am

None of those sites have the suggested ie png fix applied to their page. so dont blame joomleageu for a faulty browser feature. blame microsoft that they need ~10 years to support a common image format like png.

Again: I think this is not a Joomleague issue, because JL is not creating or resizing images, except you want it resized. And if you want that, blame the thumblib creator or the gdlib and not joomleague ;)

Last hint: Google: "IE + png + fix" and apply one of the proposed solutions to your website and try it again, if it fixes your problem. Let me know!

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Sat May 07, 2011 10:13 pm

Is there any way to go back to a previous version of JL 1.5* where the base64 encoder wasn't used for displaying images. I accept IE is rubbish in that it doesn't display correctly (regardless of PNG, JPG or GIF) when base64 is used however the bottom line is the coding change isn't compatible with what's out there being used by some of the users.

I'm not very technichal and appreciate your help.

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Mon May 09, 2011 7:51 am

Does anybody have an answer or can tell me the code to change my images from using base64 to the old method that works on all browsers?

Thank you.

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Mon May 09, 2011 11:25 am

Hopefully the silence is a good sign that somebody is considering this?

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Problem with Player pictures and IE

Postby timoline » Mon May 09, 2011 12:42 pm

:confused: :D
We have a life too....you know :whistling:
But bumping this thread wont help you to a solution either, you'd better read and try And_one' post with the IE png fix ;)
Joomla 1.5.x
Joomleague 1.5.....latest git version

cookiebtfc
.
Posts: 29
Joined: Wed May 04, 2011 2:58 pm

Re: Problem with Player pictures and IE

Postby cookiebtfc » Mon May 09, 2011 2:19 pm

And_One's fix isn't to the issue that I'm trying to bring to your attention.

I believe the issue is with the use of base64 encode, regardless of JPG, PNG or GIF, with IE7 & IE8 used by millions of users.

I would have thought that a code release that has degraded the front-end experience for users would have been a priority for you to investigate and either fix or revert the change.

I appreciate you "have a life too", I'm trying to help as all JL 1.5.1 sites will ALL be affected, isn't that the point of this forum? Have you actually bothered to check/test a logo displayed using base64 method on your own site?

User avatar
timoline
Joomleague Core Developer, Donator
Joomleague Core Developer, Donator
Posts: 3331
Joined: Thu Mar 12, 2009 8:03 am
Contact:

Re: Problem with Player pictures and IE

Postby timoline » Mon May 09, 2011 2:34 pm

yes, and I found this IE8 bug...
but it isnt as easy as you think, just by reverting the code.... we have to find another solution...

But we are still in beta so there is still time to fix it....or?
Joomla 1.5.x
Joomleague 1.5.....latest git version


Return to “1.5.1-daniela (Beta 1)”

Who is online

Users browsing this forum: No registered users and 3 guests

cron